Merged
Conversation
…dant fixtures (#779) - Expand wipe_database() with change_log, table_count_log, notification_log tables - Make clear_test_data() delegate to wipe_database() for centralized cleanup - Fix module-level dict mutation in test_database.py setup_fake_locations fixture - Remove redundant dev_db_client and clear_data_requests fixtures from conftest - Remove redundant clear_test_data() and wipe_database() calls in tests that already receive auto-cleaning fixtures - Fix MultiLocationSetup to explicitly create Pittsburgh locality - Defer data creation in notification location manager to avoid fixture ordering issues Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wipe_database()with 3 missing log tables (change_log,table_count_log,notification_log) that don't cascade from core tablesclear_test_data()by delegating towipe_database(), fixing commented-out Agency/User/Locality deletionstest_database.pythat leaked state across fixture runsdev_db_clientandclear_data_requestsfixtures and all redundant cleanup calls in tests that already receive auto-cleaning fixturesMultiLocationSetupand notification location manager to be resilient to the more thorough cleanupTest plan
uv run pytest tests -x)🤖 Generated with Claude Code