Conversation
…dlock When token_metrics_store encounters a PGRES_TUPLES_OK error, the corrupted psycopg2 connection was returned to the pool via session.remove(). Other Luigi worker threads checking out connections would hang forever on pool_pre_ping (SELECT 1), deadlocking the entire pipeline. Fix: call db.engine.dispose() before session.remove() so the corrupted connection is closed outright. Also add pool disposal as defense in depth when the _handle_task_completion callback exhausts all DB retries. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This was referenced Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
token_metrics_storeencounters aPGRES_TUPLES_OKdatabase error, the corrupted psycopg2 connection was returned to the pool viasession.remove(). Other Luigi worker threads then hang forever onpool_pre_ping(SELECT 1), deadlocking the entire pipeline at ~3% progress.db.engine.dispose()beforesession.remove()so the corrupted connection is closed outright and all threads get fresh connections._handle_task_completioncallback exhausts all 3 DB retry attempts.Test plan
PGRES_TUPLES_OKrecurs, verify workers recover instead of deadlocking)🤖 Generated with Claude Code