Skip to content

Feat/package cxx#93

Open
lwbuchanan wants to merge 3 commits intomainfrom
feat/package-cxx
Open

Feat/package cxx#93
lwbuchanan wants to merge 3 commits intomainfrom
feat/package-cxx

Conversation

@lwbuchanan
Copy link
Copy Markdown
Collaborator

Automatically installs cxxbridge-cmd to the megaton home if not already installed

Uses cargo-metadata to make sure that cxx is included in the root crate package and the semver doesn't allow for versions outside of the 'blessed' version

@lwbuchanan lwbuchanan linked an issue Apr 8, 2026 that may be closed by this pull request
@lwbuchanan lwbuchanan requested a review from Pistonight April 8, 2026 21:22
@lwbuchanan
Copy link
Copy Markdown
Collaborator Author

This is checking the wrong version data. It should check the actual installed version of cxx, not the req from the manifest.

@lwbuchanan lwbuchanan removed the request for review from Pistonight April 8, 2026 21:42
@lwbuchanan lwbuchanan requested a review from Pistonight April 8, 2026 22:10
@lwbuchanan
Copy link
Copy Markdown
Collaborator Author

Fixed the version check, but i noticed that cargo now takes longer to run after getting the metadata. Without the cxx version check, megaton build takes ~0.13s if nothing needs built. Now it takes ~0.35s. It seems like cargo build runs for a little bit longer if cargo metadata has been run since the last build. Not sure if this is a significant issue, but its a bit annoying so just mentioning in case anyone knows of a fix for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Distrubute cxx tooling with build tool

1 participant