-
Notifications
You must be signed in to change notification settings - Fork 8
chore(apps/prod): remove git-cdn from cluster prod
#1815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @ti-chi-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request systematically removes the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
[LGTM Timeline notifier]Timeline:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wuhuizuo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly removes the git-cdn application from the prod cluster by deleting its configuration files and removing it from the top-level Kustomization. The changes are straightforward and achieve the stated goal.
During the review of the removed HelmRelease, I identified two areas for improvement in its configuration that may be relevant for other services in your clusters, including other deployments of git-cdn. My comments highlight best practices for Kubernetes resource management (requests vs. limits) and persistent storage for caching, which could enhance cluster stability and application performance.
I am having trouble creating individual review comments. Click here to see my feedback.
apps/prod/git-cdn/release.yaml (32-35)
The resource configuration for git-cdn only specifies limits and not requests. In Kubernetes, when requests are omitted, they default to the values of the limits. This can lead to inefficient resource allocation and potential scheduling problems, as the scheduler will reserve the full limit amount. It is a best practice to explicitly set resource requests to a value reflecting the application's typical usage, and limits to a ceiling to prevent runaway consumption. While this component is being removed from prod, this configuration pattern might exist in other services (including other git-cdn deployments) and should be reviewed to improve cluster resource management and stability.
apps/prod/git-cdn/release.yaml (41-43)
The cache for git-cdn was configured to use an emptyDir volume. This type of volume is ephemeral and its contents are lost when a pod is terminated or rescheduled. For a caching service, this can result in poor performance due to frequent cache misses and the need to rebuild the cache from scratch, increasing load on the upstream source. Consider using a persistent volume (PersistentVolumeClaim) for caches to ensure data survives pod restarts. As git-cdn is deployed in other environments, it would be beneficial to evaluate its volume configuration there for potential performance improvements.
No description provided.