refactor(pipelines/pingcap/tidb): download componentsfrom OCI artifacts

[wuhuizuo]

Use OCI tags for PD and TiKV downloads with retry logic Containerize the
download process in utils container

[ti-chi-bot]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign purelind for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• pipelines/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[gemini-code-assist]

Summary of Changes

Hello @wuhuizuo, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors the TiDB component download mechanism within the ghpr_check2.groovy pipeline. The change moves away from a custom file server to utilizing OCI artifacts for fetching PD and TiKV, incorporating robust retry logic and encapsulating the download process within a dedicated utility container. This modernization improves the pipeline's reliability and leverages a more standardized approach for artifact management.

Highlights

• Refactored Component Downloads: The pipeline now downloads PD and TiKV components using OCI artifacts instead of a custom file server.
• Retry Logic Implemented: Added retry logic (2 retries) for OCI artifact downloads to enhance pipeline reliability.
• Containerized Download Process: The component download process has been containerized within a dedicated 'utils' container.
• Deprecated Variable Removal: The FILE_SERVER_URL environment variable, previously used for component downloads, has been removed.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the pipeline to download TiDB components (PD and TiKV) from OCI artifacts instead of a file server. This is achieved by replacing a Groovy function call with a new shell script executed within a utils container. The change aligns with the PR's goal, including adding retry logic and containerizing the download process. However, I've found a critical issue with the path to the newly introduced shell script, which will likely cause the pipeline to fail.

[gemini-code-assist]

The path to the download_pingcap_oci_artifact.sh script is incorrect. The repository is checked out into the ${REFS.repo} subdirectory within the workspace, but the script path "${WORKSPACE}/scripts/..." omits this subdirectory. This will cause a "file not found" error. Please correct the path to include the repository subdirectory.

                                        ${WORKSPACE}/${REFS.repo}/scripts/artifacts/download_pingcap_oci_artifact.sh --pd=${OCI_TAG_PD} --tikv=${OCI_TAG_TIKV}