Setup & onboarding fixes (doctor Playwright check, idempotent init, required text resume)#62
Open
sebastianmukuria wants to merge 4 commits into
Open
Conversation
- doctor adds a 'Playwright browser' check (pip does not bundle Chromium, which enrich/smart-extract/PDF all need); uses os.path.exists to avoid a swallowed NameError that would always report MISSING - init wizard warns if the browser is absent - README install block + Requirements table mention 'playwright install chromium' Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
- _setup_ai_features merges new keys into the existing .env via _merge_env, preserving CapSolver/CHROME_PATH and any manual entries (was: full rewrite) - profile.json and searches.yaml prompt before overwriting; declining keeps the existing file Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The PDF path let users skip the .txt copy, then scoring/tailoring/cover letters crashed with FileNotFoundError hours later. Loop until a valid .txt is given or the user explicitly types 'skip' (with a red warning naming the exact path to add it later). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Setup and onboarding fixes from a pre-flight review. 4 of 4 focused PRs; independent and reviewable on its own.
What & why
doctornow checks for the Playwright browser.pip installdoes not download Chromium, yet enrich, smart-extract, and PDF rendering all need it — anddoctorreported all-green without it. Added a "Playwright browser" check (carefully avoiding a swallowedNameErrorthat would always report MISSING), a README note, and an init-wizard warning. (cli.py,wizard/init.py,README.md)initno longer destroys existing config. The documented way to add an API key later is re-runninginit, but it rewrote.envfrom scratch (silently dropping a savedCAPSOLVER_API_KEY) and overwroteprofile.json/searches.yaml..envwrites now merge into the existing file; profile/searches prompt before overwriting. (wizard/init.py)skip) — the PDF-only path let setup "succeed" and then crashed scoring/tailoring/cover letters withFileNotFoundErrorhours later. (wizard/init.py)Tests
Adds
tests/test_init_env_merge.py(4 tests, all passing); the doctor check was verified manually. CHANGELOG updated under[Unreleased].