Implement PicPeak plugin with export, publish, and event features#1
Open
bmachek wants to merge 4 commits into
Open
Implement PicPeak plugin with export, publish, and event features#1bmachek wants to merge 4 commits into
bmachek wants to merge 4 commits into
Conversation
Export and Publish workflows for uploading photos to a self-hosted PicPeak gallery server via its v1 API (Bearer token auth, events + photo upload endpoints). Adapted from lrc-immich-plugin architecture. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
LR SDK rejects browsable=true with searchable=false. Set picpeakEventId to browsable=false since it's an internal tracking field, not something users need to browse in the Library filter bar. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…back Export and Publish dialogs now expose all fields supported by the PicPeak v1 POST /events endpoint: - Customer name, email, phone and admin notification email - Password protection with password field - Expiration date (ISO 8601) - Guest feedback toggle (ratings, likes, comments, favorites) - Color theme preset name Publish collection settings persist all creation params so events are auto-created with the right metadata on first publish. createEvent() in PicPeakAPI now accepts and forwards all optional fields cleanly. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
When Lightroom marks a photo as "modified / to re-publish", the rendition carries the previously recorded remote ID via publishedPhoto:getRemoteId(). We now detect this case and skip the upload, re-recording the existing PicPeak photo ID so Lightroom marks the photo as up-to-date. PicPeak v1 API has no replace/delete photo endpoint (admin-only, session auth only), so uploading again would always create a duplicate. A one-time info dialog after the run tells the user how many photos were skipped and how to force a replacement (remove → delete in PicPeak → re-add). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| - | - | Username Password | 371b95b | picpeak-plugin.lrplugin/JSON.lua | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Author
|
No secret in JSON.lua if you ask me 😊 |
Author
|
@the-luap You can merge it, if you want to. I don't think there is really a secret inside JSON.lua |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial code transfer for the Lightroom plugin from separate repository.