Skip to content

Conversation

@2826WaveRobotics
Copy link

Description

We wanted to track more than 10 objects in an Object Detection pipeline, so we added a "Maximum Targets" setting for when "Show Multiple Targets" is enabled. The default value is 10, so no existing configuration should change, though a "Show multiple targets" setting is redundant in theory.

None of the documentation mentioned this 10-object limit, so nothing there changed for now.

image

Meta

Merge checklist:

  • Pull Request title is short, imperative summary of proposed changes
  • The description documents the what and why
  • If this PR changes behavior or adds a feature, user documentation is updated
  • If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly
  • If this PR touches configuration, this is backwards compatible with settings back to v2025.3.2
  • If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated
  • If this PR addresses a bug, a regression test for it is added

@2826WaveRobotics 2826WaveRobotics requested a review from a team as a code owner January 21, 2026 03:49
@github-actions github-actions bot added frontend Having to do with PhotonClient and its related items backend Things relating to photon-core and photon-server labels Jan 21, 2026
@samfreund
Copy link
Member

Prefer increasing the hardcoded value to a sane number given the current game. We'd like to avoid adding additional sliders that can be avoided. If you're willing to add docs for the limit, go for it, but don't feel obliged.

@samfreund samfreund mentioned this pull request Jan 21, 2026
7 tasks
@mcm001 mcm001 closed this in b7a0fad Jan 22, 2026
@2826WaveRobotics
Copy link
Author

Understandable. What are your thoughts on entirely switching "Show Multiple Targets" to a "Maximum Targets" slider, given its current purpose isn't entirely clear and can be made more versatile as a configurable value? My understanding is that the existing limit is temporary, and I see use cases where teams want to track more than 50 targets to calculate a distribution of game pieces, since the current logic only returns the 50 largest in view.

@samfreund
Copy link
Member

Understandable. What are your thoughts on entirely switching "Show Multiple Targets" to a "Maximum Targets" slider, given its current purpose isn't entirely clear and can be made more versatile as a configurable value? My understanding is that the existing limit is temporary, and I see use cases where teams want to track more than 50 targets to calculate a distribution of game pieces, since the current logic only returns the 50 largest in view.

I think that sounds like a reasonable solution. This way, we don't add a new slider (our main concern being clutter and slider overload). The one note is that the max value should be set to 127, as that's the maximum PhotonVision's serialization can support.

@samfreund samfreund reopened this Jan 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend Things relating to photon-core and photon-server frontend Having to do with PhotonClient and its related items

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants