Skip to content

feat(tokens): L3-12650 align spacing tokens with design docs#860

Draft
DaveMcNamara wants to merge 1 commit into
mainfrom
spacing-tokens-update
Draft

feat(tokens): L3-12650 align spacing tokens with design docs#860
DaveMcNamara wants to merge 1 commit into
mainfrom
spacing-tokens-update

Conversation

@DaveMcNamara

@DaveMcNamara DaveMcNamara commented May 1, 2026

Copy link
Copy Markdown
Contributor

Jira ticket

L3-12650

Figma link

Figma Link

Summary

The design system spacing tokens differ quite a bit from the ones here, Seldon needs to be updated to match. Some values we previously used are no longer available.

This is a blocker for some My Account FE work, which is just waiting for the appropriate tokens to be available. First we have to make sure the spacing updates in this PR are acceptable.

Things to look for during review

  • PR title should correctly describe the most significant type of commit. I.e. feat(scope): ... if a minor release should be triggered.
  • All commit messages follow convention and are appropriate for the changes
  • All references to phillips class prefix are using the prefix variable
  • All major areas have a data-testid attribute.
  • Document all props with jsdoc comments
  • All strings should be translatable.
  • Unit tests should be written and should have a coverage of 90% or higher in all areas.

New Components

  • Are there any accessibility considerations that need to be taken into account and tested?
  • Default story called "Playground" should be created for all new components
  • Create a jsdoc comment that has an Overview section and a link to the Figma design for the component
  • Export the component and its typescript type from the index.ts file
  • Import the component scss file into the componentStyles.scss file.

@netlify

netlify Bot commented May 1, 2026

Copy link
Copy Markdown

Deploy Preview for phillips-seldon ready!

Name Link
🔨 Latest commit 6472d4e
🔍 Latest deploy log https://app.netlify.com/projects/phillips-seldon/deploys/69f4e17fbe87a500074854ea
😎 Deploy Preview https://deploy-preview-860--phillips-seldon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

github-actions Bot commented May 1, 2026

Copy link
Copy Markdown

@DaveMcNamara DaveMcNamara changed the title align spacing tokens with design docs feat(tokens): L3-12650 align spacing tokens with design docs May 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant