feat(tokens): L3-12650 align spacing tokens with design docs#860
Draft
DaveMcNamara wants to merge 1 commit into
Draft
feat(tokens): L3-12650 align spacing tokens with design docs#860DaveMcNamara wants to merge 1 commit into
DaveMcNamara wants to merge 1 commit into
Conversation
✅ Deploy Preview for phillips-seldon ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
🚀 Storybook preview is ready. • Preview: https://68b9f094608b90f3cfec5a06-djcbagyzdy.chromatic.com/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira ticket
L3-12650
Figma link
Figma Link
Summary
The design system spacing tokens differ quite a bit from the ones here, Seldon needs to be updated to match. Some values we previously used are no longer available.
This is a blocker for some My Account FE work, which is just waiting for the appropriate tokens to be available. First we have to make sure the spacing updates in this PR are acceptable.
Things to look for during review
feat(scope): ...if aminorrelease should be triggered.phillipsclass prefix are using the prefix variabledata-testidattribute.New Components
index.tsfilecomponentStyles.scssfile.