features/API-62/update-coordinates-with-socket#110
Merged
andres15alvarez merged 2 commits intodevfrom May 19, 2025
Merged
Conversation
andres15alvarez
deleted the
features/API-62/update-coordinates-with-socket
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces functionality for updating delivery coordinates via WebSocket communication. Key changes include the addition of a new DTO, enhancements to the WebSocket gateway, and updates to imports to support the new feature.
Additions to support delivery coordinates:
New DTO for delivery coordinates: Added
UpdateCoordinatesWsDTOinsrc/order/dto/order-delivery.dto.tsto handle latitude, longitude, and order ID validation. This includes new decorators like@IsLatitudeand@IsLongitudefor validation.WebSocket gateway update: Added a new
updateCoordinatesmethod insrc/order/order.gateway.tsto handle theupdateCoordinatesWebSocket event. This method validates incoming data, checks the order's user, and emits updated coordinates to the appropriate WebSocket client.Supporting changes:
src/order/dto/order-delivery.dto.tsandsrc/order/order.gateway.tsto include the newUpdateCoordinatesWsDTOand additional class-validator decorators. [1] [2]