Skip to content

fix(runtime): stringify BigInt elements in Array.prototype.join #4426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
proggeramlug merged 1 commit into from
Jun 4, 2026
+13 −0
Merged

fix(runtime): stringify BigInt elements in Array.prototype.join #4426

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions crates/perry-runtime/src/array/iter_methods.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -695,6 +695,19 @@ pub extern "C" fn js_array_join(
} else {
result.push_str("[object Object]");
}
} else if jsvalue.is_bigint() {
// BigInt elements are NaN-boxed with BIGINT_TAG (not POINTER_TAG),
// so they bypass the pointer arm above and previously fell through
// to the `[object Object]` catch-all. ToString(BigInt) is the plain
// decimal digits with NO `n` suffix (`[10n].join() === "10"`).
let s_ptr = crate::bigint::js_bigint_to_string(jsvalue.as_bigint_ptr());
if !s_ptr.is_null() {
let str_len = (*s_ptr).byte_len as usize;
let str_data = (s_ptr as *const u8).add(std::mem::size_of::<StringHeader>());
result.push_str(std::str::from_utf8_unchecked(std::slice::from_raw_parts(
str_data, str_len,
)));
}
} else if jsvalue.is_number() {
let n = jsvalue.as_number();
if n.is_nan() {
Expand Down