[codex] Align Atomics wait/notify receivers#4423
Merged
proggeramlug merged 1 commit intoJun 4, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SharedArrayBufferso Atomics wait/notify validation can distinguish shared and non-shared receivers.BigInt64Arrayreceivers forAtomics.waitandAtomics.notify, while continuing to rejectBigUint64Arrayand other typed-array kinds.Atomics.waitthrow on non-shared Int32/BigInt64 views, and makeAtomics.notifyreturn0for non-shared views after kind/index validation.Validation
timed-outforAtomics.wait(new Int32Array(new ArrayBuffer(...)))and then aborted on the firstBigInt64Arraywait withTypeError: Atomics wait/notify requires an Int32Array; Node 26 produced the expected TypeError/BigInt64 wait-notify outputs.npm exec --yes --package=node@26 -- node --experimental-strip-types test-parity/node-suite/globals/atomics-wait-notify-receivers.tsatomics-wait-notify-receivers.tswithPERRY_NO_AUTO_OPTIMIZE=1 PERRY_ALLOW_UNIMPLEMENTED=1; Node/Perry diff empty.test-parity/node-suite/globals/atomics-wait-notify.ts; diff empty.CARGO_TARGET_DIR=/root/perry-worktrees/perry-node-webcrypto-cryptokey-property-exposure-20260604/target cargo check -q -p perry-runtime --libRUSTFLAGS="-Awarnings" CARGO_TARGET_DIR=/root/perry-worktrees/perry-node-webcrypto-cryptokey-property-exposure-20260604/target cargo build -q -p perry-runtimeRUSTFLAGS="-Awarnings" CARGO_TARGET_DIR=/root/perry-worktrees/perry-node-webcrypto-cryptokey-property-exposure-20260604/target cargo build -q -p perrycargo fmt --all -- --checkgit diff --check HEAD~1..HEAD./scripts/check_file_size.shNote: the full
run_parity_tests.shharness was not used because it builds/uses releasetarget/release/perry; this cut was validated with direct Node/Perry fixture comparisons using the rebuilt debug CLI and runtime archive.