fix(node): route domain errors from native EventEmitter#4402
Closed
andrewtdiz wants to merge 3 commits into
Closed
fix(node): route domain errors from native EventEmitter#4402andrewtdiz wants to merge 3 commits into
andrewtdiz wants to merge 3 commits into
Conversation
Contributor
|
Superseded by #4398 ("fix(domain): route emitter errors through domains"), which already merged and closed the same issue #4395. main's domain-error routing (incl. the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4395.
Summary:
new EventEmitter()/new events.EventEmitter()through the native events handle path used by the no-auto events archive.domain.add/remove,ee.domain, and unhandlederroremits work across stdlib and native events handles.Validation:
PERRY_NO_AUTO_OPTIMIZE=1 target/release/perry compile test-parity/node-suite/domain/members-emitter-errors.ts -o /tmp/perry-domain-members-debug --debug-symbols --no-cache && /tmp/perry-domain-members-debugPERRY_NO_AUTO_OPTIMIZE=1 target/release/perry compile test-parity/node-suite/events/imports/default-import.ts -o /tmp/perry-events-default-import --debug-symbols --no-cache && /tmp/perry-events-default-importPERRY_NO_AUTO_OPTIMIZE=1 target/release/perry compile test-parity/node-suite/events/imports/named-imports.ts -o /tmp/perry-events-named-imports --debug-symbols --no-cache && /tmp/perry-events-named-importsPERRY_NO_AUTO_OPTIMIZE=1 target/release/perry compile test-parity/node-suite/events/imports/namespace-import.ts -o /tmp/perry-events-namespace-import --debug-symbols --no-cache && /tmp/perry-events-namespace-importenv CARGO_BUILD_JOBS=1 RUSTC_WRAPPER= cargo check -p perry-ext-events -p perry-runtime -p perry-stdlibenv CARGO_BUILD_JOBS=1 RUSTC_WRAPPER= cargo test -p perry-runtime native_handle -- --nocaptureenv CARGO_BUILD_JOBS=1 RUSTC_WRAPPER= cargo test -p perry-runtime test_write_barrier_non_pointer -- --nocapturerustfmt --edition 2021 --check <touched files>git diff --check