[codex] dispatch crypto getFips callable exports#4345
Draft
andrewtdiz wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #3955.
Summary
getFipscallable export to Node's default non-FIPS value0Why
Direct
crypto.getFips()already lowers statically to0, but callable export dispatch did not have agetFipsarm. That madeimport { getFips } from "node:crypto"; getFips()diverge from Node's default FIPS-disabled behavior.Validation
NODE26_BIN=$(npm exec --yes --package=node@26 -- node -e 'console.log(process.execPath)'); "$NODE26_BIN" --experimental-strip-types --no-warnings test-parity/node-suite/crypto/inventory/fips-api.tscargo build -p perry -p perry-stdlibcargo build -p perry-runtimePERRY_ALLOW_UNIMPLEMENTED=1 PERRY_NO_AUTO_OPTIMIZE=1 PERRY_RUNTIME_DIR=$PWD/target/debug target/debug/perry compile --no-cache test-parity/node-suite/crypto/inventory/fips-api.ts -o /root/perry-worktrees/.tmp-node-crypto-fips/fips-api && /root/perry-worktrees/.tmp-node-crypto-fips/fips-apicargo test -p perry-stdlib crypto_native_dispatch_get_fips_matches_default_node_mode -- --nocapturecargo fmt --all -- --checkgit diff --check./scripts/check_file_size.sh