Skip to content

[codex] align global File identity with node:buffer#4344

Draft
andrewtdiz wants to merge 1 commit into
PerryTS:mainfrom
andrewtdiz:codex/node-buffer-global-file
Draft

[codex] align global File identity with node:buffer#4344
andrewtdiz wants to merge 1 commit into
PerryTS:mainfrom
andrewtdiz:codex/node-buffer-global-file

Conversation

@andrewtdiz
Copy link
Copy Markdown
Contributor

@andrewtdiz andrewtdiz commented Jun 4, 2026

Summary

  • wires global File to the stdlib File allocator so global File, globalThis.File, and node:buffer File share constructor identity
  • routes new globalThis.File(...), rebound constructor calls, and computed dynamic constructor calls through the same File factory
  • exposes File-backed Blob handle metadata through generic property dispatch and extends the buffer global-file parity fixture

Validation

  • cargo fmt --all -- --check
  • git diff --check
  • ./scripts/check_file_size.sh
  • cargo check -p perry-hir -p perry-codegen -p perry-runtime -p perry-stdlib
  • cargo build -p perry -p perry-runtime -p perry-stdlib
  • cargo build --release -p perry -p perry-runtime -p perry-stdlib
  • PATH=... PERRY_NO_AUTO_OPTIMIZE=1 ./run_parity_tests.sh --suite node-suite --module buffer --filter global-file
  • direct Node 26 and Perry debug run of test-parity/node-suite/buffer/blob-file/global-file.ts

@andrewtdiz andrewtdiz force-pushed the codex/node-buffer-global-file branch from 101af22 to 3fef003 Compare June 4, 2026 05:19
@andrewtdiz andrewtdiz changed the title [codex] node: align global File identity [codex] align global File identity with node:buffer Jun 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant