[codex] honor sync child_process numeric stdio fds#4342
Closed
andrewtdiz wants to merge 1 commit into
Closed
Conversation
Contributor
|
Superseded by the merged combination of #4284 ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #2555.
Summary
options.stdiostring/array forms forspawnSync(),execFileSync(), andexecSync(), including numeric fd entries.fs.openSync()file table, with a Unix raw-fd fallback for externally supplied descriptors.nullstdout/stderr slots when sync stdout/stderr are not piped.execFileSync()errors, and stdin fd input.Scope
This is a narrow sync-only slice of #2555. It intentionally leaves live
spawn()/fork()numeric fds to #4284 and keeps custom stream handles, invalid-fd validation, AbortSignal/killSignal, uid/gid, detached/platform flags, and broad option validation out of this cut.Validation
PATH="/root/.npm/_npx/bac97da9607b7ef2/node_modules/node/bin:$PATH" node --experimental-strip-types test-parity/node-suite/child_process/sync/sync-stdio-fd.tsPERRY_ALLOW_UNIMPLEMENTED=1 PERRY_NO_AUTO_OPTIMIZE=1 PERRY_RUNTIME_DIR=/root/perry-worktrees/perry-node-child-process-stdio-fd-tail/target/debug target/debug/perry compile --no-cache test-parity/node-suite/child_process/sync/sync-stdio-fd.ts -o /tmp/perry_sync_stdio_fd_debugrt/tmp/perry_sync_stdio_fd_debugrtCARGO_TARGET_DIR=/root/perry-worktrees/.build-targets/perry-child-stdio-fd-check cargo check -p perry-runtime(existing warnings)cargo build -p perry-runtime(existing warnings)cargo fmt --all -- --checkgit diff --check./scripts/check_file_size.shThe full focused
run_parity_tests.sh --suite node-suite --module child_process --filter sync-stdio-fdpath could not complete in this environment because the required release compiler/runtime build terminated before producing a binary/report and emitted no Rust diagnostic. The fixture was therefore verified through a direct no-cache Perry compile/run linked against the freshly built debug runtime archive.