[codex] fix Node Web Storage globals#4341
Draft
andrewtdiz wants to merge 1 commit into
Draft
Conversation
This was referenced Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #812.
localStorageandsessionStorageobjects from the reflected global descriptor getters instead ofundefined.Storage.prototype.lengthits own receiver-aware getter so it keeps the existing illegal-invocation behavior.lengthdata slot by clearing and restoring attrs around the update.globals/storage-globalswith descriptor getter coverage.Root Cause
The Web Storage globals installed reflectable accessor descriptors, but the shared getter stub always returned
undefined. After exposing the actual storage objects through the descriptor getters, storage mutations also hit an existing internal update path that wrote to the readonlylengthproperty through normal property assignment and threw.Known Limit
This keeps the existing in-memory/process-local Web Storage behavior. It does not change persistence or flag handling.
Validation
npm exec --package=node@26 -- node --experimental-webstorage --localstorage-file=/tmp/perry_web_storage_parity.sqlite test-parity/node-suite/globals/storage-globals.tsglobals/storage-globals, thendiff -u /tmp/perry_storage_node.out /tmp/perry_storage_run.outcleanCARGO_TARGET_DIR=/root/perry-worktrees/.build-targets/node-web-storage-globals npm exec --package=node@26 -- bash -lc './run_parity_tests.sh --suite node-suite --module globals --filter storage-globals'-> pass, reporttest-parity/reports/parity_report_20260604_040722.jsonCARGO_TARGET_DIR=/root/perry-worktrees/.build-targets/node-web-storage-globals cargo check -p perry-runtimecargo fmt --all -- --checkgit diff --check./scripts/check_file_size.sh