Skip to content

fix(runtime): bind inherited prototype accessors#4339

Draft
andrewtdiz wants to merge 1 commit into
PerryTS:mainfrom
andrewtdiz:codex/node-trace-events-receiver-state
Draft

fix(runtime): bind inherited prototype accessors#4339
andrewtdiz wants to merge 1 commit into
PerryTS:mainfrom
andrewtdiz:codex/node-trace-events-receiver-state

Conversation

@andrewtdiz
Copy link
Copy Markdown
Contributor

Summary

  • bind inherited accessor getters found through Perry's synthetic prototype-object chain to the original receiver
  • fixes node:trace_events Tracing instances so categories, enabled, enable(), and disable() operate on the instance instead of the prototype object
  • keeps the existing synthetic prototype/data-method lookup path intact for non-accessor properties

Tracks #812.

Validation

  • Baseline before the fix: CARGO_TARGET_DIR=/root/perry-worktrees/.build-targets/node-trace-events-receiver-state npm exec --package=node@26 -- bash -lc './run_parity_tests.sh --suite node-suite --module trace_events' (2 pass, 4 fail, report test-parity/reports/parity_report_20260604_031212.json)
  • CARGO_TARGET_DIR=/root/perry-worktrees/.build-targets/node-trace-events-receiver-state npm exec --package=node@26 -- bash -lc './run_parity_tests.sh --suite node-suite --module trace_events --filter state' (1 pass, 0 fail, report test-parity/reports/parity_report_20260604_031908.json)
  • CARGO_TARGET_DIR=/root/perry-worktrees/.build-targets/node-trace-events-receiver-state npm exec --package=node@26 -- bash -lc './run_parity_tests.sh --suite node-suite --module trace_events' (6 pass, 0 fail, report test-parity/reports/parity_report_20260604_032057.json)
  • CARGO_TARGET_DIR=/root/perry-worktrees/.build-targets/node-trace-events-receiver-state cargo check -p perry-runtime (passes with existing warnings)
  • cargo fmt --all -- --check
  • git diff --check
  • ./scripts/check_file_size.sh

Notes

  • node-suite/object/reflect-proxy-construct still has an unrelated output mismatch; it reproduces on unchanged origin/main in the scan worktree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant