- Changed the stub method to resolvesArg#218
Open
amit-singhs wants to merge 2 commits intoPermissionless-Software-Foundation:masterfrom
Open
- Changed the stub method to resolvesArg#218amit-singhs wants to merge 2 commits intoPermissionless-Software-Foundation:masterfrom
resolvesArg#218amit-singhs wants to merge 2 commits intoPermissionless-Software-Foundation:masterfrom
Conversation
Author
|
I'm currently working on a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The proper way to use an identity function as a stub for a promise in sinon.js is to use
resolvesArg(0). Because of this thetokensattribute was set to an anonymous function instead of the expected value.And the funny thing is the test was passing because it was only checking the length attribute to be one, which would also be true for an anonymous function.