separate commits for animations and IBDesignable#3
Open
farshidce wants to merge 2 commits intoPerfectFreeze:swift-3.0from
Open
separate commits for animations and IBDesignable#3farshidce wants to merge 2 commits intoPerfectFreeze:swift-3.0from
farshidce wants to merge 2 commits intoPerfectFreeze:swift-3.0from
Conversation
made changes to ensure that the min and max values are set properly and the bottom button text is updated based on the min value
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have broken the pull request into two separate commits
the first one addresses the "IB*" issue and the second one resolves the animation.
I also got rid of those extra ; and fixed another bug i found in my previous implementation so i closed the previous PR
I tried to make the "animation" a separate pull request based on the 1dbdc1a commit instead of the 3c97271 but ran into merge issues ( because needsAnimation is also @IBInspectable as well ) so kept this PR as it is.
I will update the README file with more documentation about the usage later and send you a new PR as well.