Open
Conversation
| ) { | ||
| safe.push(charCode); | ||
| } else { | ||
| safe.push('H'.charCodeAt(0)) // ugly fix |
There was a problem hiding this comment.
Are any of these visible? If not then maybe don't push here.
Author
There was a problem hiding this comment.
They are visible characters. It can be triggered by inputting the corresponding character as a variable name, costume name, etc.
There was a problem hiding this comment.
But if it's ugly, then wouldn't it be better to have them not show up at all?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a bug on Scratch that breaks the Blockly XML when a character such as "\u0015" is entered, effectively making the project's contents invisible. This partially patches that, although I couldn't get it to work in all cases.