Skip to content

Conversation

@justjuangui
Copy link
Contributor

Description

This PR:

  • Support "dyamic" attributes
  • Improve "rotation" attrribute with right click
  • Support for "unlockBy" in options for attributes nodes
  • Check for invalidate attribute selection
  • Backward Compatibility for previous save
  • Import & Save support

Format with backward compatibility

image

Evidence

image image image

@Nightblade
Copy link
Contributor

Please fix spelling before this is merged. ❤️

tomatosource

This comment was marked as duplicate.

@FinalLightNL
Copy link

was about to request this as a update, glad someone is working on it.
thanks POB team 🙏

@tomatosource
Copy link

@Nightblade / @justjuangui Hey guys - HNY :)
Any chance of getting this merged?

I fixed up spelling mistakes on a branch here if that makes life easier: #1682

@justjuangui
Copy link
Contributor Author

@Nightblade / @justjuangui Hey guys - HNY :) Any chance of getting this merged?

I fixed up spelling mistakes on a branch here if that makes life easier: #1682

HNY too,

thx for the help, but like Local said we was on vacation, and i just arrive, but just to keep in mind, even if i fix, it doenst mean that it will merge soon, because depends on maintainers :D, this week i will fix this PR in my branch.

Copy link
Member

@Wires77 Wires77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the spelling for you. Do we know what happens in game when you deallocate this node? Right now those nodes turn into "+5 to any attribute", which isn't ideal.

Looks like this also broke the hotkeys specified in the popup menu
image

Finally, we should parse the contents of the ascendancy node so people know it's implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants