Fix Exposed Accessibility Skip Link due to CSS Syntax Error#356
Merged
Conversation
…Connect Us in a single row
Owner
|
@Divyanshu227 Resolve conflicts by Syncing the Respective Branch |
PatelHarsh2006
added
gssoc:approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issuenum: #292
Description
This PR resolves a visual issue on orders.html and cart.html where the "Skip to main content" accessibility link was persistently visible as unstyled black text on a white background above the header.
Root Cause
In css/style.css (line 2234), the closing curly brace (}) for the style rule ::-webkit-scrollbar-thumb:hover was missing. Because of this syntax error, the browser's CSS parser failed to process the subsequent .skip-link styles correctly, leaving the accessibility skip link unstyled and visible by default at the top of the viewport.
Proposed Changes
Stylesheet Fix (css/style.css)
Added the missing closing curly brace } to seal the ::-webkit-scrollbar-thumb:hover styling rule.
This successfully enables the browser to parse and apply the .skip-link absolute positioning rule (top: -40px;), hiding it off-screen on initial page load as intended.
/gssoc26