Skip to content

feat(core-config): add unsaved changes confirmation dialog#466

Closed
ArthurKoba wants to merge 1 commit into
PasarGuard:devfrom
ArthurKoba:dev
Closed

feat(core-config): add unsaved changes confirmation dialog#466
ArthurKoba wants to merge 1 commit into
PasarGuard:devfrom
ArthurKoba:dev

Conversation

@ArthurKoba
Copy link
Copy Markdown

  • Implement change tracking for core configuration editor
  • Block modal close when unsaved changes exist
  • Show confirmation dialog with options to keep editing or discard changes
  • Add translations for all supported languages (en, ru, fa, zh)
  • Reset dirty state after successful save operation

Solving the issue: #459

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 11, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 86c81549-dfe9-4176-9cb5-db819f3ae486

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ImMohammad20000
Copy link
Copy Markdown
Contributor

this will change in feauture

@ArthurKoba
Copy link
Copy Markdown
Author

ArthurKoba commented May 11, 2026

Yes, I saw your message, but by the time I made the implementation. How soon are you planning to make changes to this section and release it? If it's not that soon or the process drags on, and there's an interim release or a fix in the main, then I think PR can be useful for at least some time.

@ImMohammad20000
Copy link
Copy Markdown
Contributor

There is no but in feature versions

@ArthurKoba
Copy link
Copy Markdown
Author

I hope there won't be a similar problem when editing kernels in the future.

@ArthurKoba ArthurKoba closed this May 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants