Analyzer to ensure AddHandler<T> isn't called on a saga type #7559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidBoike
requested review from
andreasohlund,
danielmarbach and
mattmercurio
andreasohlund
approved these changes
Dec 13, 2025
| public class OrderPolicy : Saga<OrderPolicyData>, | ||
| IAmStartedByMessages<OrderPlaced>, | ||
| IAmStartedByMessages<OrderBilled>, | ||
| IHandleTimeouts<OrderPlaced> // Should not also use a message as timeout state in real life! |
Member
There was a problem hiding this comment.
We have docs that promote this https://docs.particular.net/nservicebus/sagas/timeouts#timeout-state-using-the-incoming-message-as-a-timeout-state
| } | ||
|
|
||
| [Test] | ||
| public void SagaWithInappropriateDoubleMessageMapping() |
Member
There was a problem hiding this comment.
Should the test name be "SagaThatIsResusingMessageAsTimeoutState"?
danielmarbach
approved these changes
Dec 13, 2025
|
|
||
| var handlerFullyQualifiedName = handlerType.ToDisplayString(SymbolDisplayFormat.FullyQualifiedFormat); | ||
| return new HandlerSpec(InterceptLocationSpec.From(location), handlerType.Name, handlerFullyQualifiedName, registrations); | ||
| var handlerTypeSpec = HandlerTypeSpec.From(handlerType); |
| } | ||
|
|
||
| (string methodName, HandlerSpec handlerSpec) = first; | ||
| HandlerSpec first = group.First(); |
Contributor
There was a problem hiding this comment.
I originally went with avoiding LINQ for efficiency reasons. It seems, though, LINQ is smart enough in this case to see that the enumerable is an array and therefore always accesses the first element so I'm OK leaving it as is
src/NServiceBus.Core.Analyzer/Handlers/AddHandlerInterceptor.cs
Outdated
Show resolved
Hide resolved
Contributor
|
I would wait with merging until we discussed #7560 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.