Removing grid.py and time_origin for v4#2068
Merged
Merged
Conversation
As time will become a datetime64?timedelta64 object, no need anymore for time_origin and TimeConverter
Contributor
|
Before we can merge this, I think we need to also get rid of the old grid class entirely (its not used anymore - was just keeping it for reference, but we're passed that stage now). I'll work on it today |
Member
Author
|
Oh I can also do that; was actually planning on doing this the coming few days (hence the draft status of this PR). I'm getting pretty good at removing old code ;-) |
Contributor
|
Cool, sounds good. It will require removing |
24 tasks
erikvansebille
changed the title
VeckoTheGecko
requested changes
Jul 8, 2025
VeckoTheGecko
left a comment
VeckoTheGecko
left a comment
Contributor
There was a problem hiding this comment.
Looks good! Just some further removal of code then I think we're good to go!
Contributor
|
|
VeckoTheGecko
approved these changes
Jul 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As time will become a
np.datetime64/np.timedelta64object, no need anymore fortime_originandTimeConverter. This PR removes them.It also removes the old grid.py
mainfor v3 changes,v4-devfor v4 changes)