Scope assert_valid_lat_lon for >0D grids#2058
Merged
Merged
Conversation
VeckoTheGecko
changed the title
assert_valid_lat_lon for 0D gridsassert_valid_lat_lon for >0D grids
4 tasks
erikvansebille
approved these changes
Jun 30, 2025
VeckoTheGecko
force-pushed
the
xgrid-interp
branch
from
ef33429 to
de0a616
Compare
VeckoTheGecko
force-pushed
the
zero-d-grid
branch
from
2b3261e to
86f5d09
Compare
This was in v3 of parcels and isn't needed anymore
Adds a `.axes` attribute to help with the check (in line with development - see #2054)
VeckoTheGecko
force-pushed
the
zero-d-grid
branch
from
1f0de68 to
8f93773
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2037 introduced some functionality for checking the provided lon and lat grids. This, however, does not apply to constant fields which have 0D spatial grids.
This PR also adds the
XGrid.axesattribute (in line with #2056) and removes the.lonlat_minmaxattribute used in v3.This PR disables the check for these grids as they don't have a lon/lat grid provided. The lon/lat assertion would need to be revisited in #2054.
Merge after #2037 (just splitting into a different PR for review-ability, rather than piling into the same one)
v4-dev<-xgrid-interp)