Update FieldSet.gridset to use a list#2057
Merged
Merged
Conversation
Not needed anymore now that in v4 fields are explicitly stored in FieldSet.fields
8fc9617 to
aa8bf42
Compare
Also remove `FieldSet.gridset_size` which was used as a patch
aa8bf42 to
e28b486
Compare
erikvansebille
approved these changes
Jun 30, 2025
41451cc to
a342ca5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates
FieldSet.gridsetto be a list ofBaseGridinstances (i.e., XGrid of UxGrid objects). It also removesFieldSet.get_fields()since we now have thefieldsdictionary.Note that to see if grids are the same, this code looks at whether the grid objects point to the same location in memory (this is the default with the
... in ...when working with custom objects) . This results in something like:This is because calling
XGridtwice results in two differentXGridobjects in memory despite them having the same arguments. I think that this is fine (I don't really see an usecase where this would limit us) - keen to discuss if someone has a different opinion on this.v4-devfor v4 changes)