[DRAFT: Discussion] 2034 v4 particleset execute#2046
Closed
fluidnumericsJoe wants to merge 13 commits into
Closed
Conversation
This is needed for consistency of grid access independent of whether we are referencing a scalar or vector field.
This property is needed for determining min/max depth bounds in particleset.__init__ . With consistency between XGrid and UXGrid, this getting depth ranges with either grid type can be accomplished with the same code in particleset.__init__
This commit also cleans up a few sections of init for working with the new field/fieldset API.
Currently, we don't have support for igrid selection
This prevents errors in the field.eval calls for constant in time fields
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainfor v3 changes,v4-devfor v4 changes)