Skip to content

Cleaning out some no-longer relevant v3 tests#2042

Merged
VeckoTheGecko merged 9 commits into
v4-devfrom
test-cleanup
Jun 19, 2025
Merged

Cleaning out some no-longer relevant v3 tests#2042
VeckoTheGecko merged 9 commits into
v4-devfrom
test-cleanup

Conversation

@VeckoTheGecko

@VeckoTheGecko VeckoTheGecko commented Jun 18, 2025

Copy link
Copy Markdown
Contributor
  • Chose the correct base branch (v4-dev for v4 changes)
  • Fixes None

Grid de-deplication will be handled another (simpler) way in v4.
Already have test_fieldset_add_field_already_exists in v4 suite.
Originally introduced in 8639e1d . I'm not entirely sure what it does, but I think this will be handled by the xarray data model.
Already handled natively
Now that we rely on xarray internally:
- test_fieldset_from_data_timedims (origin is 0f4de2c)
- test_fieldset_from_data_different_dimensions (origin is c6eb804)
Already in v4 test suite
Not relevant now due to xarray data model
@VeckoTheGecko VeckoTheGecko marked this pull request as ready for review June 19, 2025 11:52
@VeckoTheGecko VeckoTheGecko changed the title Cleaning out no-longer relevant v3 tests Cleaning out some no-longer relevant v3 tests Jun 19, 2025
@VeckoTheGecko VeckoTheGecko merged commit b2b0146 into v4-dev Jun 19, 2025
6 of 11 checks passed
@VeckoTheGecko VeckoTheGecko deleted the test-cleanup branch June 19, 2025 12:31
@github-project-automation github-project-automation Bot moved this from Backlog to Done in Parcels development Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants