2031 uxgrid vertical search#2032
Conversation
|
@VeckoTheGecko - The piecewise linear interpolation is still broken on unstructured grid due to some strange indexing/memory error. However, this should give a gist of what could be done to enable vertical search and would be a good first cut for FESOM2 demos. I have a few more tests I'd like to put in to make sure that at least piecewise constant is correct for fields that are linear in |
This commit adds a test case to verify we can exactly interpolate fields that depend linearly on z. Additionally, this commit fixes the previously failing `test_fesom2_square_delaunay_uniform_z_coordinate_eval`. The fix for the apparent memory bug is to reference `field.values`
fluidnumericsJoe
changed the title
|
On the unit test that is failing. when I run the full suite of |
In the new test I incorporated, updating the data set to modify values changes the expected values for tests called after it. Looking into a workaround here |
This comment was marked as off-topic.
This comment was marked as off-topic.
|
Indeed this was test pollution. For one of the tests, I was overwriting the values stored by the pressure and vertical velocity; tests that were run later on that also used the same dataset ended up failing assertions due to the change in the underlying data. Solution here was to do a deep copy of the dataset for the test where pressure and vertical velocity are modified, rather than using the dataset provided by our |
2 participants
mainfor v3 changes,v4-devfor v4 changes)This PR introduces changes that enable vertical search for unstructured Grids. This currently assumes that z-layer coordinates are used with no partial or shaved cells.
For the vertical interpolation, we now test interpolation of fields that are uniform in space and time and those that vary linearly with depth.
Additionally, fixes are introduced in the
application_kernels/interpolation.pythat resolve previous test failures fortest_fesom2_square_delaunay_uniform_z_coordinate_eval