feat: add SEO for home, dashboard, and event pages#91
Open
Conversation
runzhao3
requested review from
RaymondWHZ and
louisunlimited
and removed request for
RaymondWHZ
louisunlimited
requested changes
Sep 6, 2023
Member
louisunlimited
left a comment
louisunlimited
left a comment
There was a problem hiding this comment.
Great work! Just a few fixes and we'll pick up from there
Added several features like twitter card, themecolor, viewport, and canonical Formated og::image better through revising its path and name
Collaborator
Author
|
Have revised all the issues you have mentioned. You can review them and point out any further improvement that occurs on your mind. |
louisunlimited
requested changes
Sep 18, 2023
Collaborator
Author
|
Have made the change |
louisunlimited
requested changes
Sep 22, 2023
louisunlimited
requested changes
Oct 12, 2023
| <> | ||
| <Head> | ||
| <link rel="icon" href="/favicon.ico" /> | ||
| <link rel="icon" href="/public/fav_icon.png" /> |
Member
There was a problem hiding this comment.
We don't need /public here as per above 🍡
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I used next-seo to implement seo and revise browser titles for all major pages.
Please take a look at whether the format I added the para-og1 is correct for og, also whether I still need to include next-head for twitter og.