Conversation
bkueng
reviewed
Jun 2, 2025
Member
bkueng
left a comment
bkueng
left a comment
There was a problem hiding this comment.
Nice, thanks.
Out of curiosity, where do you intend to use it?
Contributor
Author
|
I intend to use this with QGC on NixOS. As with most patches I apply to packages, I submit a PR to integrate the changes upstream so that there are no subtle differences between the packaged version and the official upstream. Having them be separate packages instead of using CPM has a couple of advantages in terms of end-user customizability and simplification of the build process (build environments have no networking, meaning that CPM can't fetch the git repo). |
Pandapip1
force-pushed
the
better-build-config
branch
from
d16e7f1 to
df0fb04
Compare
Pandapip1
force-pushed
the
better-build-config
branch
from
df0fb04 to
c59c5ae
Compare
Contributor
Author
|
Changes have been addressed! |
bkueng
approved these changes
Jun 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds cmake configuration to make ulog_cpp installable as a normal system library. This patch will be applied by NixOS.