Open
Conversation
…back for tests until full protocol is deployed
ashhanai
reviewed
Dec 15, 2025
| revert DurationTooShort(); | ||
| } | ||
|
|
||
| // TODO should here be >= or just > |
Member
There was a problem hiding this comment.
It doesn't really matter, but >= allows to have no installments until end of the loan.
Comment on lines
+102
to
+105
| // TODO should we check the values here that they are correct? | ||
|
|
||
| // TODO should we check here that the getCollateralAmount on installments product contract returns | ||
| // positive result (to ensure that the feeds are set up correctly)? |
Comment on lines
+323
to
+330
| // TODO shall we keep this as `public`, or only as `external` since so far it's not used internally anywhere? | ||
| // TODO same question for: | ||
| // 1) totalAssets | ||
| // 2) deposit | ||
| // 3) mint | ||
| // 4) withdraw | ||
| // 5) redeem | ||
| // 6) previewCollateralRedeem |
Member
There was a problem hiding this comment.
If it's not used, change to external.
| // TODO should we adjust this to <= also in other Product contracts? | ||
| // TODO should we revert on any other place if encountered price is 0 or negative, or is this okay to do just here? | ||
| if (price <= 0) { | ||
| revert ChainlinkFeedReturnedNegativePrice({ feed: address(feed), price: price, updatedAt: updatedAt }); |
Member
There was a problem hiding this comment.
Ideally change the error. It's not just negative. Remove the todos.
microHoffman
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.