Add method attribute for PHP 8.1 compatibility#8
Open
emteknetnz wants to merge 1 commit intoPTCInc:masterfrom
Open
Add method attribute for PHP 8.1 compatibility#8emteknetnz wants to merge 1 commit intoPTCInc:masterfrom
emteknetnz wants to merge 1 commit intoPTCInc:masterfrom
Conversation
Author
GuySartorelli
approved these changes
Apr 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the following deprecation warning when running PHP 8.1
Deprecated: Return type of Apache_Solr_Document::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/vendor/ptcinc/solr-php-client/Apache/Solr/Document.php on line 301You can read about this specific attribute here https://php.watch/versions/8.1/ReturnTypeWillChange
Could you please tag
v1.0.1once this is merged. Thanks.