-
-
Notifications
You must be signed in to change notification settings - Fork 163
Add CLI --behavior option
#2981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
dcd44f6
Add CLI --behavior option without its logic
martinholmer 88bb163
Revise docs wrt new CLI --behavior option
martinholmer cd4e30f
More docs changes wrt new CLI --behavior option
martinholmer b78a4fe
Add CLI --behavior logic to TaxCalcIO constructor
martinholmer eb4b691
Add tests to increase code coverage
martinholmer fbc42c6
Read BEHAVIOR file and check its contents
martinholmer c528408
Add tests of new TaxCalcIO.init behavior logic
martinholmer f357041
Edit error message in taxcalcio.py module
martinholmer 10452a2
Refactor new TaxCalcIO.init tests wrt --behavior option
martinholmer b3ae7ed
Step 1 in adding behavior logic to TaxCalcIO.analyze
martinholmer 1c709af
Step 2 in adding behavior logic to TaxCalcIO.analyze
martinholmer 931dc04
Step 3 in adding behavior logic to TaxCalcIO.analyze
martinholmer 76bf553
Step 4 in adding behavior logic to TaxCalcIO.analyze
martinholmer 1f32bf9
Add brtest target to Makefile
martinholmer d49c33b
Step 5 in adding behavior logic to TaxCalcIO.analyze
martinholmer d926aa7
Add test of CLI assuming behavioral responses
martinholmer 4ad29bb
Modify new test
martinholmer 06fc8ec
Add cleanup code to new test
martinholmer 5f92d2e
Modify handling of MTR variables in TaxCalcIO
martinholmer 5391fc9
Revise Calculator test to increase code coverage
martinholmer 73af87d
Strengthen 'make brtest' tests
martinholmer 3028693
Improve CLI messages
martinholmer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| Behavior parameters | ||
| =================== | ||
|
|
||
| Note that logic that uses assumed behavior parameters to compute | ||
| changes in input variables caused by a tax reform in a | ||
| partial-equilibrium setting is not part of Tax-Calculator. The | ||
| [`response` | ||
| function](https://github.com/PSLmodels/Behavioral-Responses/blob/232abc1e6b9f0a2b2f224ad887af3c19019d28d3/behresp/behavior.py#L13-L50) | ||
| in the PSLmodels Behavioral-Responses `behresp` package contains that | ||
| logic. | ||
|
|
||
| By default Tax-Calculator assumes no behavioral responses to a tax | ||
| reform, which is the same as saying the behavior parameters (or | ||
| elasticities) are assumed to be zero by default. The elasticities can | ||
| be set to non-zero values in a JSON file that is formatted like | ||
| [this](https://github.com/PSLmodels/Tax-Calculator/blob/master/taxcalc/behavior/behavior_response_template.json)). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| Assumption parameters | ||
| ===================== | ||
|
|
||
| This section contains documentation of several sets of parameters that characterize responses to a tax reform. Consumption parameters are used to compute marginal tax rates and to compute the consumption value of in-kind benefits. Growdiff parameters are used to specify baseline differences and/or reform responses in the annual rate of growth in economic variables. (Note that behavior parameters used to compute changes in input variables caused by a tax reform in a partial-equilibrium setting are not part of Tax-Calculator, but can be used via the Behavioral-Response `behresp` package in a Python program.) | ||
| This section contains documentation of several sets of parameters that characterize responses to a tax reform. Consumption parameters are used to compute marginal tax rates and to compute the consumption value of in-kind benefits. Growdiff parameters are used to specify baseline differences and/or reform responses in the annual rate of growth in economic variables. | ||
|
|
||
| The assumption parameters control advanced features of Tax-Calculator, so understanding the source code that uses them is essential. Default values of many assumption parameters are zero and are projected into the future at that value, which implies no response to the reform. The benefit value consumption parameters have a default value of one, which implies the consumption value of the in-kind benefits is equal to the government cost of providing the benefits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.