version 5.3.0 release

[bodiyang]

This pull request prepares Tax-Calculator 5.3.0 release.

Please check the release documentation for updates from this version.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (b441c7f) to head (f097ac7).
⚠️ Report is 21 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff            @@
##            master     #2958   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines         2662      2667    +5     
=========================================
+ Hits          2662      2667    +5     

Flag	Coverage Δ
unittests	100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
taxcalc/__init__.py	100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[martinholmer]

@bodiyang wrote in PR #2958:

Note: PUF users are required to produce new `puf.csv` 
file from Tax-Data model and replace the old file in the
Tax-Calc directory.
Correct usage: Tax-Calc >= 5.3.0 versions are compatible 
with the newly produced `puf.csv` file; Tax-Calc <= 5.2.0 
versions are compatible with the previous `puf.csv` file.

This needs correction. There is no repository named Tax-Data and few people would call the puf-data-preparation code a model.
Also, there is no Tax-Calc repository or package. This statement is very confusing.

[martinholmer]

@bodiyang said in the top comment in PR #2958:

This pull request prepares Tax-Calc 5.3.0 release.

Again, there is no such thing as Tax-Calc. Please fix this.

[martinholmer]

@bodiyang and @jdebacker,

Please wait for a few days to release 5.3.0

I'm going to implement the removal of PUF-related files from the Tax-Calculator repository as agreed in the discussion of PR 2925.

[bodiyang]

@bodiyang and @jdebacker,

Please wait for a few days to release 5.3.0

I'm going to implement the removal of PUF-related files from the Tax-Calculator repository as agreed in the discussion of PR 2925.

Was talking with @jdebacker that there needs to be changes in TaxData as well. As mentioned in the comment "refactoring the TaxData package".

Would PR 2538 need to be done after that?

[martinholmer]

@bodiyang said in PR #2958:

Would 
https://github.com/PSLmodels/Tax-Calculator/pull/2538
need to be done after that?

No, removing the puf-related files and tests in the Tax-Calculator repo has nothing to do with improvements in the taxdata repo. I'm planning a new PR, not using the old Tax-Calculator PR #2538.

[martinholmer]

@bodiyang, You should revise the releases.md description of release 5.3.0 in PR #2958 to reflect the changes in PR #2961, which has been awaiting review by @jdebacker since Monday, September 15th.

[jdebacker]

@bodiyang Can you change this to todays date and I'll merge?

[martinholmer]

@jdebacker, PR #2958 needs to INCLUDE PR #2961.
So don't merge it and release 5.3.0 until PR #2961 is merged.

[jdebacker]

@martinholmer Can you explain why 5.3.0 would need to include PR #2961?

It seems to me the main item in this version bump are updates to the PUF-related files from PR #2925. So why not release a version that works with those and then another version after PR #2961 that removes them? Then there is at least one version of taxcalc for those using the previous API for PUF files.

[martinholmer]

@jdebacker said in PR #2958:

It seems to me the main item in this version bump are updates to the PUF-related files from PR #2925. So why not release a version that works with those and then another version after PR #2961 that removes them? Then there is at least one version of taxcalc for those using the previous API for PUF files.

OK, so long as release 5.4.0 follows 5.3.0 by just a few days.

[jdebacker]

Thanks @bodiyang for preparing this release.