cNF Modularization And Call Scripts #3
Conversation
|
Should be ready - let me know if you have any questions. |
sgosline
left a comment
sgosline
left a comment
There was a problem hiding this comment.
Just a few documentation issues - otherwise it's pretty close.
1- please add comments to helper files and descriptions/context in the R markdowns.
2- clearly separate out scripts/functions from analysis. The scripts/functions should be data/batch agnostic (which I think they are) . The analysis sections can be re-run as we get more analyses, but shoudl also explain what you are doing, why you are doing it, and maybe provide some support for the result.
3- no binary files in github if you can avoid it. this includes docx.
There was a problem hiding this comment.
Github doesn't really support binary files - can you please remove? Maybe you can move to an R MD (maybe create a separate 'analysis' folder and date the analysis you did.
There was a problem hiding this comment.
can you please add some comments to the functions so it's clear what each of them does?
There was a problem hiding this comment.
is this something that would be run with every analysis/batch? or is it a one-off? if the latter - move to an analysis folder, date it, and add some more context/description. If it something to be run with every batch, then move it to a .R file.
There was a problem hiding this comment.
move to an analysis folder, proide more context/description.
Modularized the batch correction code, the correlation analysis code, and the leapR code so each could be called with a function call from one of 3 scripts across each of the modalities (RNA, global, phospho).
Also added in the figure and analysis description word doc.