feat: update resource_request schema to require only one of resourceType and resourceName#75
Open
akryukov378 wants to merge 1 commit into
Open
feat: update resource_request schema to require only one of resourceType and resourceName#75akryukov378 wants to merge 1 commit into
akryukov378 wants to merge 1 commit into
Conversation
akryukov378
commented
Nov 25, 2025
akryukov378
commented
Collaborator
- Es wurde eine oneOf-Einschränkung hinzugefügt, um sicherzustellen, dass genau eines der Felder resourceType oder resourceName vorhanden ist.
- Das Beispiel wurde aktualisiert, um beide gültigen Muster zu veranschaulichen.
- resourceRequestId bleibt für alle Ressourcenanfragen obligatorisch.
…ype or resourceName - Changed required fields from both resourceType and resourceName to just resourceRequestId - Added oneOf constraint to ensure exactly one of resourceType or resourceName is present - Updated example to demonstrate both valid patterns - resourceRequestId remains mandatory for all resource requests
akryukov378
commented
Nov 25, 2025
| "oneOf": [ | ||
| { | ||
| "required": ["resourceType"], | ||
| "not": { |
Collaborator
Author
There was a problem hiding this comment.
@mjoerg78 ist "not required" nicht überflüssig? Das bedeutet optional, was ohnehin default ist.
Collaborator
Author
There was a problem hiding this comment.
Auf der anderen Seite habe ich mir kurz überlegt - anscheinend ist es gar nicht möglich die "genau eines"-Semantik zu erzwingen. Ich versuche noch zu experimentieren.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.