Chromium integration

[Tobianas]

No description provided.

[gemini-code-assist]

Code Review

This pull request upgrades OpenDaylight (ODL) dependencies and plugins, refactors gNMI module dependencies to use ODL gNMI artifacts instead of local models, and introduces a new lighty-gnmi-device-simulator wrapper module. It also updates configuration loading and classpath model resolution utilities. The review feedback highlights several improvement opportunities: explicitly defined dependency versions in lighty-rcgnmi-app-module/pom.xml should be managed by the imported BOM, potential InputStream resource leaks exist in RcGnmiAppModuleConfigUtils.java due to unclosed streams, and the ServiceLoader lookup in getModelsFromClasspath is inefficient and should be optimized by pre-loading providers into a map.

I am having trouble creating individual review comments. Click here to see my feedback.

lighty-applications/lighty-rcgnmi-app-aggregator/lighty-rcgnmi-app-module/pom.xml (53-71)

The versions for certificates-storage-model, force-capabilities, topology-model, and yang-storage-model are explicitly set to 1.0.0. Since org.opendaylight.gnmi:gnmi-artifacts (version 3.0.0-SNAPSHOT) is imported in dependency-versions/pom.xml, these dependencies should have their versions managed automatically. Specifying 1.0.0 explicitly overrides the managed version and can lead to version mismatch issues. Please remove the <version> tags.

        <dependency>
            <groupId>org.opendaylight.gnmi</groupId>
            <artifactId>certificates-storage-model</artifactId>
        </dependency>
        <dependency>
            <groupId>org.opendaylight.gnmi</groupId>
            <artifactId>force-capabilities</artifactId>
        </dependency>
        <dependency>
            <groupId>org.opendaylight.gnmi</groupId>
            <artifactId>topology-model</artifactId>
        </dependency>
        <dependency>
            <groupId>org.opendaylight.gnmi</groupId>
            <artifactId>yang-storage-model</artifactId>
        </dependency>

lighty-applications/lighty-rcgnmi-app-aggregator/lighty-rcgnmi-app-module/src/main/java/io/lighty/applications/rcgnmi/module/RcGnmiAppModuleConfigUtils.java (85)

The InputStream returned by Files.newInputStream(path) is not closed, which can lead to a resource leak if an exception is thrown or even during normal execution. Use a try-with-resources block to ensure the stream is properly closed.

        GnmiConfiguration gnmiConfiguration;
        try (InputStream is = Files.newInputStream(path)) {
            gnmiConfiguration = getGnmiConfiguration(is);
        }

lighty-applications/lighty-rcgnmi-app-aggregator/lighty-rcgnmi-app-module/src/main/java/io/lighty/applications/rcgnmi/module/RcGnmiAppModuleConfigUtils.java (96)

The InputStream returned by Files.newInputStream(path) is not closed, which can lead to a resource leak. Use a try-with-resources block to ensure the stream is properly closed.

        final ModulesConfig modulesConfig;
        try (InputStream is = Files.newInputStream(path)) {
            modulesConfig = ModulesConfig.getModulesConfig(is);
        }

lighty-applications/lighty-rcgnmi-app-aggregator/lighty-rcgnmi-app-module/src/main/java/io/lighty/applications/rcgnmi/module/RcGnmiAppModuleConfigUtils.java (152-164)

Iterating over ServiceLoader inside a loop (filterYangModelBindingProviders is called for each QName in filter) is highly inefficient because ServiceLoader traversal can be slow. Instead, pre-load the providers into a map once, and then look them up by QName. Additionally, Collections.unmodifiableSet(resolvedModules.values().stream().collect(Collectors.toSet())) can be simplified to Set.copyOf(resolvedModules.values()) for better readability and performance.

    public static Set<YangModuleInfo> getModelsFromClasspath(final Set<QName> filter) {
        Map<QName, YangModuleInfo> resolvedModules = new HashMap<>();
        ServiceLoader<YangModelBindingProvider> yangProviderLoader = ServiceLoader.load(YangModelBindingProvider.class);
        Map<QName, YangModuleInfo> allProviders = new HashMap<>();
        for (YangModelBindingProvider provider : yangProviderLoader) {
            YangModuleInfo info = provider.getModuleInfo();
            allProviders.put(info.getName(), info);
        }
        for (QName moduleId : filter) {
            YangModuleInfo info = allProviders.get(moduleId);
            if (info != null) {
                resolvedModules.put(info.getName(), info);
                addDependencies(resolvedModules, info.getImportedModules());
            }
        }
        return Set.copyOf(resolvedModules.values());
    }

[Tobianas]

Rebased on #2622