Do not override odlparent managed versions#396
Open
Tobianas wants to merge 2 commits into
Open
Conversation
Because LYV uses lighty-minimal-parent, it now inherits strict ODL checkstyle which requires <p> to have no space after it. JIRA: LIGHTY-427 Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech>
We have some dependencies we usually bump according to odlparent. Assuming they are managed by ODL we do not need to manage them in lighty.io as well. JIRA: LIGHTY-427 Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes explicit version declarations for the logback and org.json dependencies, as well as the maven-resources-plugin, from the pom.xml file. It also includes a minor Javadoc formatting update in the Main.java file. I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.