update github action so macOS build runs on intel or apple processors#82
update github action so macOS build runs on intel or apple processors#82
Conversation
|
@bpow I am planning to actually officially release this code in about 6 months, and although I have asked you and a few other people to kick the tires, I am not sure the additional complexity is worth it? Is this a concrete blocker for somebody at CG? I would also prefer just making separate Mac installers in that case, from what I see it it also not too complicated to implement as an action. |
|
As you might imagine, working in academia we sometimes have the combination of having institutional restrictions on software use and not having the latest and greatest hardware. The senior biocurator who is planning to look into this was not able to install the windows version because of institutional restrictions, and the "loaner" mac we identified for her to use is an older one with intel processor. In the meantime, I can work around this by building the intel mac version manually, but if she identifies issues or use cases that you'd potentially address and like to have her re-test, then it would be easier (and faster since I wouldn't need to be in the loop), to have the intel mac version built along with your standard release pipeline. Complexity of a "universal" mac build vs. separate installers is a tradeoff-- the former is larger and a little more complicated in the build script, but the latter avoids potential confusion on the part of users as to which they need... If you'd rather use separate installers for arm64 vs. intel on mac, you can look at my branch at https://github.com/bpow/phenoboard/tree/build-macos-separate-arch as an alternative. |
|
@bpow I adapted the code of this PR slightly (by hand) but the current script is now essentially identical. Could you please try the latest release: https://github.com/P2GX/phenoboard/releases/tag/v0.5.124 |
Fixes #67. There are still some macs out there with intel processors. This PR changes
the github action to create a "universal" binary supporting both intel and arm64 processors
in the mac OS .dmg build.