a lot#256
Open
0dm wants to merge 21 commits into
Open
Conversation
…llisions # Conflicts: # include/app/Renderer.hpp # include/app/SauceEngineApp.hpp # include/editor/EditorApp.hpp # include/launcher/optionParser.hpp # src/app/SauceEngineApp.cpp # src/editor/EditorApp.cpp # src/launcher/optionParser.cpp # src/main.cpp
Resolved CMakeLists: keep consolidated branch layout; drop duplicate find_package/target_sources from main. Resolved Renderer.hpp: ScenePushConstants at namespace scope for pipeline config; remove duplicate viewport/scissor before push constants. Made-with: Cursor
Made-with: Cursor
Build System:
- Fix CMake slangc detection (if(!) → if(NOT))
- Remove WIN32 guard blocking editor shader compilation on Windows
- Replace hardcoded absolute path in modeltest.cpp with relative path
- Remove unused tinyobjloader from vcpkg.json
Cross-Platform Runtime:
- Implement Windows play mode via CreateProcess (was "not implemented")
- Implement Windows stopPlayMode via TerminateProcess
- Add cross-platform getEngineExecutablePath for Windows (GetModuleFileNameW)
- Move settings file to OS-appropriate config directory (APPDATA/Library/XDG)
- Replace system("start ...") with ShellExecuteA for browser launch on Windows
Bug Fixes:
- Fix redundant eGraphics|eGraphics queue family check → eGraphics|eCompute
- Fix deltaFrame double initialized with float literal (0.0f → 0.0)
- Propagate window resize to editor camera aspect ratio
- Replace assert() with throw in critical Vulkan init paths
- Fix Mesh::isValid() to reject non-multiple-of-3 index counts
Code Quality:
- Add non-const Renderer getters, remove all const_cast<vk::raii::*> calls
- Rename app from "Vulkan Playground" to "SauceEngine"
- Unify duplicate initPipeline/initPipelineConfigurable into single method
- Replace isPhysicsDemoScene filename heuristic with RigidBodyComponent scan
NoahFreelove
force-pushed
the
super-monkey-ball
branch
from
093805f to
88a1f5f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
its a lot dont even bother reviewing
i dont know why theres so many files i think some of them are from other branches i merged into this one while working