[#245] Light Components Depth Mapping Resources#249
Open
ziadzananiri wants to merge 4 commits into
Open
Conversation
Collaborator
ziadzananiri
commented
Mar 23, 2026
- DirectionalLightComponent, PointLightComponent, and SpotLightComponent now have a DescriptorSetLayout attribute for descriptor sets. (code is very redundant ik)
- Added depthImage, depthImageMemory, depthImageView, depthSampler, and depthDescriptorSet as members to DirectionalLightComponent, PointLightComponent, and SpotLightComponent.
- DirectionalLightComponent, PointLightComponent, and SpotLightComponent now also have new methods: initDescriptorSetLayout(), getDescriptorSetLayout(), cleanup(), and initDepthMappingResources() for managing their descriptor set states.
- Created a new method uploadLightGPUResources() in SauceEngineApp. This method iterates through all the entities in the scene that have any of the light components and calls their initDepthMappingResources() method.
…ted a function in the SauceEngineApp to initialize current light component descriptor sets
EthanVinceBudan
previously requested changes
Mar 25, 2026
Collaborator
EthanVinceBudan
left a comment
There was a problem hiding this comment.
Unfortunately there's no way to test this at the moment but it seems mostly ok👍Other than one small note, I did see a validation error on shutdown (pretty sure the descriptor set layout doesn't get cleaned up). As you pointed out, there's definitely some repetition in the DescriptorSetLayout code; I would recommend refactoring into LightComponent so you only have to worry about init & cleanup once instead of once per light type. Should help fix that error too.
…ightComponent.cpp, updated all the previous light components, CMakeLists, and SauceEngineApp light logic
Collaborator
Collaborator
Author
|
branch was very behind from main, i pulled, plz check again |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
