Remove duplicate SphereBVHNode::isLeaf() definition#234
Merged
FriedricNietzsche merged 2 commits intoMar 16, 2026
Conversation
Co-authored-by: FriedricNietzsche <142739679+FriedricNietzsche@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on IBL ambient lighting integration
Remove duplicate Mar 16, 2026
SphereBVHNode::isLeaf() definition
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SphereBVHNode::isLeaf()was defined twice inSphereBVH.cpp(lines 246 and 296), causing a compilation error due to duplicate symbol.Changes
src/physics/SphereBVH.cpp: Removed the redundant second definition ofisLeaf()at line 296; the canonical definition at line 246 is retained.🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.