Open
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #55 +/- ##
===========================================
- Coverage 88.35% 77.44% -10.92%
===========================================
Files 31 38 +7
Lines 1323 1516 +193
Branches 46 55 +9
===========================================
+ Hits 1169 1174 +5
- Misses 139 327 +188
Partials 15 15 |
BeLeap
requested changes
Apr 20, 2023
…eEngine/feat/physics-particle
…eEngine/feat/physics-particle
BeLeap
requested changes
Jun 29, 2023
BeLeap
reviewed
Jun 29, 2023
BeLeap
requested changes
Aug 14, 2023
Member
BeLeap
left a comment
BeLeap
left a comment
There was a problem hiding this comment.
There is plenty of warnings from github actions. Please check.
| }); | ||
| } | ||
| if duration <= 0.0 { | ||
| return Err("Cannot integrate with zero duration"); |
Member
There was a problem hiding this comment.
I think defining custom error using enum is better than using string as error
Member
There was a problem hiding this comment.
| use oxide_math::commons::vector::*; | ||
| use oxide_math::commons::vector3::Vector3; | ||
|
|
||
| extern crate generational_arena; |
Member
There was a problem hiding this comment.
extern crate is no longer needed.
utilForever
requested changes
Sep 2, 2023
Member
utilForever
left a comment
utilForever
left a comment
There was a problem hiding this comment.
First of all, you should fix cargo clippy issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added particle and particle-force generator.
Registration for p-f generators are not implemented yet.
Added AABB for shapes Ball and Cuboid.
Local AABB is for object space, and AABB is for world space. Currently AABB only supports translations.
Planning to replace translation vector with homogenous coordinate matrix , to scaling and rotations.
Key changes
To Be Done