Adds in actor which utilizes service to add permission to collection#357
Open
Adds in actor which utilizes service to add permission to collection#357
Conversation
Author
|
I meant to draft this. Not ready for merge yet since it needs tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@lsat12357 I want to write some tests for this, but I'd like your input on this. I plugged into the actor stack to utilize a new actor which adds the permissions. The service already exists in hyrax, so i'm just utilizing that here instead of creating my own
Hyrax::Collections::PermissionsCreateService. It still utilizes the state machine structure and adheres to that. Only difference is that i'm calling the method on the service in a different spot than the other ones typically do (seen on lines 48 and 53)