chore(examples): untrack stellar contract target/ and gitignore it#160
Merged
Conversation
Cargo build output for examples/basic-react-app/contracts/stellar-demo-staking was committed by mistake (~230 MB, 758 files). The example React app does not reference any artifact under target/ — it's regenerated locally by `cargo build`, matching how the sibling evm-demo's Foundry `out/` directory is handled. Adds **/contracts/**/target/ to .gitignore to mirror the existing Foundry rules. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
✅ Deploy Preview for openzeppelin-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
examples/basic-react-app/contracts/stellar-demo-staking/target/(Cargo build output, ~230 MB / 758 files) was committed by mistake. The example React app does not reference any artifact undertarget/— greppingsrc/,vite.config.ts,package.json,index.html, andpublic/fordemo-staking,demo_staking,.wasm, ortarget/returns zero hits.contracts/evm-demo/) treats build output the same way: its Foundryout/directory is not tracked and is already covered by**/contracts/**/out/in.gitignore. There was simply no equivalent rule for Cargo'starget/.**/contracts/**/target/to.gitignoreto mirror the existing Foundry rules so future Soroban builds don't leak back in.Anyone building the contract can regenerate
target/locally withcargo build/stellar contract build.Test plan
examples/basic-react-appstill builds:pnpm --filter @openzeppelin/ui-example-basic-react-app buildgit check-ignore examples/basic-react-app/contracts/stellar-demo-staking/target/CACHEDIR.TAGreports the file as ignored on this branch🤖 Generated with Claude Code