fix(access&tokens): l-06 code simplifications

[0xisk]

Types of changes

What types of changes does your code introduce to OpenZeppelin Midnight Contracts?
Put an x in the boxes that apply

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation Update (if none of the other choices apply)

Partially #431

PR Checklist

• I have read the Contributing Guide
• I have added tests that prove my fix is effective or that my feature works. See GUIDELINES.md#testing for more information.
• I have added documentation for new methods or changes to existing method behavior. See GUIDELINES.md#documentation for more information.
• CI Workflows Are Passing

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Summary by CodeRabbit

• Refactor
  • Optimized internal implementation of access control and token approval logic for improved efficiency.

---

Note: This release contains internal optimizations with no changes to user-facing functionality or public APIs.

[coderabbitai]

Walkthrough

Two smart contract functions are refactored to reduce code complexity: AccessControl._unsafeGrantRole consolidates account insertion logic outside a conditional block, and NonFungibleToken.isApprovedForAll replaces if/else branching with a single boolean expression.

Changes

Cohort / File(s)	Summary
AccessControl Simplification contracts/src/access/AccessControl.compact	Removed redundant lines by moving account insertion and return statement outside the conditional initialization block, consolidating the logic path.
NFT Approval Logic Simplification contracts/src/token/NonFungibleToken.compact	Refactored isApprovedForAll to use a single chained boolean expression (member/lookup chain) instead of if/else branching structure.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Two functions trimmed with careful care,
Redundant paths removed from here and there,
Boolean chaining flows so clean and neat,
Code simplifications make the logic sweet! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Linked Issues check	⚠️ Warning	The PR partially addresses linked issue #431. It implements the two AccessControl simplifications and the NonFungibleToken simplification but does not implement the primary Uint128._mul optimization recommended in the issue.	Implement the Uint128._mul optimization by aligning partial 64-bit products to their positions and processing all words at each position in one operation, as specified in issue #431.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The PR title 'fix(access&tokens): l-06 code simplifications' directly describes the code simplifications made to AccessControl and NonFungibleToken as specified in linked issue #431.
Out of Scope Changes check	✅ Passed	All changes in the PR directly correspond to code simplifications recommended in linked issue #431; no out-of-scope modifications are present.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/l-06

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}