fix(access): l-04 misleading documentations regarding default admin role

[0xisk]

Types of changes

What types of changes does your code introduce to OpenZeppelin Midnight Contracts?
Put an x in the boxes that apply

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation Update (if none of the other choices apply)

Fixes #429

PR Checklist

• I have read the Contributing Guide
• I have added tests that prove my fix is effective or that my feature works. See GUIDELINES.md#testing for more information.
• I have added documentation for new methods or changes to existing method behavior. See GUIDELINES.md#documentation for more information.
• CI Workflows Are Passing

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Summary by CodeRabbit

Release Notes

• Refactor
  • Updated the default admin role handling to use an explicit function that returns zero bytes, replacing the previous constant approach. This clarifies the default admin role behavior and ensures consistency across the system.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 9fef5a59-5c00-4fc9-8526-997e6e1250f8

📥 Commits

Reviewing files that changed from the base of the PR and between 25aa666 and 37ad882.

📒 Files selected for processing (2)

• contracts/src/access/AccessControl.compact
• contracts/src/access/test/mocks/MockAccessControl.compact

---

Walkthrough

Converted DEFAULT_ADMIN_ROLE from a ledger constant to a pure circuit function returning zero bytes, eliminating misleading documentation that implied the value could be customized while it always returned the default value.

Changes

Cohort / File(s)	Summary
AccessControl Contract contracts/src/access/AccessControl.compact	Replaced ledger constant DEFAULT_ADMIN_ROLE with a pure circuit function that returns default<Bytes<32>>. Updated getRoleAdmin() to call the function instead of referencing storage. Clarified module documentation to reflect that the default admin role is explicitly zero bytes and not customizable.
Mock AccessControl contracts/src/access/test/mocks/MockAccessControl.compact	Removed AccessControl_DEFAULT_ADMIN_ROLE from exports and added a new pure circuit DEFAULT_ADMIN_ROLE() function that delegates to the underlying implementation.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Poem

🐰 A constant masquerading as choice,
Now shines as truth—a function's voice!
Zero bytes forever pure and clear,
No more confusion, all sincere. ✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: fixing misleading documentation regarding the DEFAULT_ADMIN_ROLE in AccessControl by converting it from a ledger constant to a pure circuit function.
Linked Issues check	✅ Passed	The PR successfully addresses issue #429 by removing the stored DEFAULT_ADMIN_ROLE ledger entry and replacing it with a pure circuit function, while updating documentation to clarify that the default admin is explicitly zero bytes.
Out of Scope Changes check	✅ Passed	All changes are directly scoped to fixing the DEFAULT_ADMIN_ROLE issue: modifications to AccessControl.compact and MockAccessControl.compact align with the requirement to remove the ledger entry and update behavior.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/l-04

Warning

Review ran into problems

🔥 Problems

Timed out fetching pipeline failures after 30000ms

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}